[openib-general] [PATCH] [cma] qp_access_flags was changed to zero

[Sean Hefty]

Dotan Barak wrote:
>  	qp_attr.qp_state = IB_QPS_INIT;
> -	qp_attr.qp_access_flags = IB_ACCESS_LOCAL_WRITE;
> +	qp_attr.qp_access_flags = 0;
>  	qp_attr.port_num = id_priv->id.port_num;
>  	return ib_modify_qp(qp, &qp_attr, IB_QP_STATE | IB_QP_ACCESS_FLAGS |
>  					  IB_QP_PKEY_INDEX | IB_QP_PORT);
> 

Does this cause a problem that you run into?  (trying to gauge the severity here 
- I'm guessing that this just sets a bit that's ignored by the lower level driver)

I think there's a related issue in the ib_cm, which also sets 
IB_ACCESS_LOCAL_WRITE.  The above code is executed when the user calls 
rdma_create_qp().  The ib_cm routine is executed when connecting the QP, which 
will overwrite these settings.  I think we'll want to change both places to get 
the desired result.

- Sean