[openib-general] [PATCH 1/2] ib/core/uverbs: return sq_draining value in query_qp response
Jack Morgenstein
jackm at dev.mellanox.co.il
Wed Oct 25 03:54:20 PDT 2006
Return the sq_draining value back to user space for query_qp instead
of the en_sqd_async notify value. This last is valid only for
modify_qp. For query_qp, the draining status should returned.
Signed-off-by: Jack Morgenstein <jackm at mellanox.co.il>
---
Roland,
Without this patch, can't manage sq draining via polling.
Furthermore, without the patch, userspace query_qp does
not comply with the IB Spec.
Finally, the ABI structure change is only a name change -
no need to increment the ABI version.
Can this be queued for 2.6.19?
Index: ofed_1_1/drivers/infiniband/core/uverbs_cmd.c
===================================================================
--- ofed_1_1.orig/drivers/infiniband/core/uverbs_cmd.c 2006-08-03 14:30:21.000000000 +0300
+++ ofed_1_1/drivers/infiniband/core/uverbs_cmd.c 2006-10-25 12:16:02.818144000 +0200
@@ -1216,7 +1216,7 @@ ssize_t ib_uverbs_query_qp(struct ib_uve
resp.qp_access_flags = attr->qp_access_flags;
resp.pkey_index = attr->pkey_index;
resp.alt_pkey_index = attr->alt_pkey_index;
- resp.en_sqd_async_notify = attr->en_sqd_async_notify;
+ resp.sq_draining = attr->sq_draining;
resp.max_rd_atomic = attr->max_rd_atomic;
resp.max_dest_rd_atomic = attr->max_dest_rd_atomic;
resp.min_rnr_timer = attr->min_rnr_timer;
Index: ofed_1_1/include/rdma/ib_user_verbs.h
===================================================================
--- ofed_1_1.orig/include/rdma/ib_user_verbs.h 2006-08-03 14:31:48.000000000 +0300
+++ ofed_1_1/include/rdma/ib_user_verbs.h 2006-10-25 12:15:29.119097000 +0200
@@ -456,7 +456,7 @@ struct ib_uverbs_query_qp_resp {
__u8 cur_qp_state;
__u8 path_mtu;
__u8 path_mig_state;
- __u8 en_sqd_async_notify;
+ __u8 sq_draining;
__u8 max_rd_atomic;
__u8 max_dest_rd_atomic;
__u8 min_rnr_timer;
More information about the general
mailing list