[openib-general] [PATCH 1/2] ib/core/uverbs: return sq_draining value in query_qp response

[Jack Morgenstein]

On Wednesday 25 October 2006 16:09, Roland Dreier wrote:
>  > Finally, the ABI structure change is only a name change -
>  > no need to increment the ABI version.
> 
> I don't believe this is true unfortunately.  If you have a new
> libibverbs and an old kernel, then you will return the value of
> en_sqd_async_notify to the consumer but tell the consumer that the
> value represents sq_draining.
> 
Why is this any worse than having a situation where a kernel module
has a bug in which it returns an incorrect value in an ABI field in
which no name change is involved?

If we fix such a bug, do we need to increment the ABI as well?

( I do agree, though, that the sq_draining case pushes the above
  argument to the limit. I was aware of your observation above.
  I'm just uncomfortable with needing to increment the ABI version
  for all bug fixes, and I treat the above - including the name change -
  as a bug fix).

- Jack