[openib-general] [PATCH 1/14] NetEffect iWarp RNIC driver

[Glenn Grundstrom]

One question regarding the userspace diff paths.  I've scanned other
email submissions and seen several different paths used that were
accepted.  All of the following have previously been used.

osm/opensm/osm_pkey_mgr.c
last_stable/src/userspace/libmthca/src/verbs.c
src/device.c 

Seems like I should use new/src/userspace/libnes/* to follow the
Mellanox style.  Is that correct?
For the kernel code I will use new/drivers/infiniband/hw/nes/*.

Thanks,
Glenn.

-----Original Message-----
From: Tom Tucker [mailto:tom at opengridcomputing.com] 
Sent: Thursday, October 26, 2006 9:20 AM
To: Glenn Grundstrom; openib-general at openib.org
Subject: Re: [openib-general] [PATCH 1/14] NetEffect iWarp RNIC driver

Glenn:

Thanks for posting the NES driver patch. This is great.

When you post a patch there are a few conventions that people usually
follow:

- The patch contents should not be an attachment. This is because people
like to reply to your patch with comments inline and including the patch
as an attachment does not facilitate this.

- BTW, You need to be careful with your mailer. Some mailers mess with
the white space.

- All patches should be plain text, not uuencoded, etc...

- The patchset should include a [PATCH 0/x] mail message that describes
what the patchset is for, "NES 10Gb RNIC Driver" or somesuch.

- Each patch should contain a signature line:
    Signed-off-by: Glenn Grundstrom <ggrundstrom at neteffect.com>

Take a look at some of the patches that have been submitted recently for
examples.

Also, here are some write ups with more extensive guidelines...

http://linux.yyz.us/patch-format.html
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Please repost per the above and we'll get started.

Thanks again,
Tom



On 10/25/06 7:06 PM, "Glenn Grundstrom" <ggrundstrom at NetEffect.com>
wrote:

> The following set of patches contain the source code for the NetEffect

> NE010 adapter.  Patches 1 through 9 contain the kernel driver source 
> and patches 10 through 14 contain the userspace components.  Due to 
> license restrictions the NetEffect TCP/IP stack module cannot be 
> released under the OFA license, but is available from NetEffect under 
> a separate license agreement.  NetEffect is in the process of 
> developing a TCP stack that will meet the OFA license requirements.  
> For information on licensing the NetEffect TCP stack module, contact 
> openfabrics at neteffect.com.
> 
> Signed-off-by: Glenn Grundstrom <glenng at neteffect.com>
> 
> 
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit 
> http://openib.org/mailman/listinfo/openib-general