[openib-general] [PATCH] IB/mthca: fix MAD extended header format

Roland Dreier rdreier at cisco.com
Mon Oct 30 07:44:46 PST 2006


 > Roland, the offsets look wrong. Am I missing something?
 > Please review vs the spec, and if correct consider for 2.6.19.

I just applied your original patch without checking it carefully :)
Yes, the offsets in your patch look like they match the PRM now.
However:

 > +#define MAD_IFC_RLID_OFFSET   0x10e

I don't see anything about RLID in either the latest Tavor or Arbel
specs -- they say the RLID goes in the input modifier (as the current
mthca code also does).  So is putting the RLID into the mailbox
needed?  Or should we follow the docs?

 - R.




More information about the general mailing list