[openib-general] [PATCH] for 2-6-19 rdma/addr: use client registration to fix module unload race

Roland Dreier rdreier at cisco.com
Tue Oct 31 10:49:02 PST 2006


 > @@ -305,6 +330,7 @@ int rdma_resolve_ip(struct sockaddr *src
 >  		break;
 >  	default:
 >  		ret = req->status;
 > +		atomic_dec(&client->refcount);
 >  		kfree(req);
 >  		break;
 >  	}

Doesn't this need to be deref_client() here too?  Or is there some
reason why this can't be the last reference to the client?

(BTW, I really find the "deref" name confusing -- it makes me think of
dereferencing a pointer, rather than putting a reference.  I would use
put_client() instead)

 - R.




More information about the general mailing list