[openib-general] 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile error

Andrew Morton akpm at osdl.org
Fri Sep 1 14:03:13 PDT 2006


On Fri, 01 Sep 2006 13:51:32 -0700
Roland Dreier <rdreier at cisco.com> wrote:

>     Andrew> No, driver-specific workarounds are not legitimate, sorry.
> 
>     Andrew> The driver should simply fail to compile on architectures
>     Andrew> which do not implement __raw_writeq().
> 
> But how should i386 (say) implement __raw_writeq()?  As two
> __raw_writel()s protected by a spinlock (that serializes all IO
> transactions)?  That seems rather ugly.
> 

If it's a choice between "ugly" and "doesn't work on x86", we'll take
"ugly" ;)




More information about the general mailing list