[openib-general] [Bug 218] New: Call usage verifier is detecting reinitialization of spinlocks already in use

[bugzilla-daemon at openib.org]

http://openib.org/bugzilla/show_bug.cgi?id=218

           Summary: Call usage verifier is detecting reinitialization of
                    spinlocks already in use
           Product: OpenFabrics Windows
           Version: unspecified
          Platform: X86
        OS/Version: Other
            Status: NEW
          Severity: major
          Priority: P2
         Component: mthca driver
        AssignedTo: bugzilla at openib.org
        ReportedBy: jbottorff at xsigo.com


I built a debug version of revision 467 and turned on call usage verifier (CUV)
for the mthca driver. It's detecting many cases of spinlocks being initialized
after they have already been used. This is usually bad. To build with CUV all
you have to do is add the following line to the sources file.

VERIFIER_DDK_EXTENSIONS=1

My experience is CUV tends to detect a different set of bugs from driver
verifier, and it might be useful to turn on CUV for all the drivers and see
what's reported.

CUV Driver Error: Calling KeInitializeSpinLock(...) at File
k:\windows-openib\src\winib-467b\hw\mthca\kernel\mt_spinlock.h, Line 57
                  The Spin lock specified as parameter 1 [0x87840EDC]
                  has been previously initialized and used as
                  a In-Stack Queued Spin lock by this driver.
Break, Ignore, Zap, Remove, Disable all, H for help (bizrdh)? b
b
Breaking in... (press g<enter> to return to assert menu)
Break instruction exception - code 80000003 (first chance)
nt!DbgBreakPoint:
8075cc00 cc               int     3
0: kd> k 50
ChildEBP RetAddr  
f7926438 baeab189 nt!DbgBreakPoint
f7926450 baeaa814 mthca!DDKExtPrompt+0x10a
[d:\dnsrv\sdktools\ddk\ddk_ext\verifier\messages.cpp @ 709]
f7926468 baea990e mthca!DDKExtVInitializeItem+0x98
[d:\dnsrv\sdktools\ddk\ddk_ext\verifier\validate.cpp @ 195]
f7926490 bae81635 mthca!DDK_KeInitializeSpinLock+0x35
[d:\dnsrv\sdktools\ddk\ddk_ext\verifier\locks.cpp @ 298]
f79264a4 baea42ee mthca!spin_lock_init+0x15
[k:\windows-openib\src\winib-467b\hw\mthca\kernel\mt_spinlock.h @ 58]
f79264b0 baea4057 mthca!mthca_wq_init+0xe
[k:\windows-openib\src\winib-467b\hw\mthca\kernel\mthca_qp.c @ 383]
f792653c bae7eaac mthca!mthca_modify_qp+0xe97
[k:\windows-openib\src\winib-467b\hw\mthca\kernel\mthca_qp.c @ 853]
f7926550 bae76eaa mthca!ibv_modify_qp+0x1c
[k:\windows-openib\src\winib-467b\hw\mthca\kernel\mt_verbs.c @ 467]
f7926628 ba99e0f3 mthca!mlnx_modify_qp+0x11a
[k:\windows-openib\src\winib-467b\hw\mthca\kernel\hca_verbs.c @ 955]
f792673c ba99df12 ibbus!al_modify_qp+0x113
[k:\windows-openib\src\winib-467b\core\al\al_qp.c @ 1346]
f7926760 ba99d7b8 ibbus!modify_qp+0x502
[k:\windows-openib\src\winib-467b\core\al\al_qp.c @ 1313]
f7926778 ba99eef5 ibbus!ib_modify_qp+0x18
[k:\windows-openib\src\winib-467b\core\al\al_qp.c @ 1288]
f7926848 ba99ec9e ibbus!init_dgrm_svc+0x175
[k:\windows-openib\src\winib-467b\core\al\al_qp.c @ 1453]
f7926870 ba96d005 ibbus!ib_init_dgrm_svc+0x73e
[k:\windows-openib\src\winib-467b\core\al\al_qp.c @ 1395]
f7926c4c ba969fd8 ibbus!create_spl_qp_svc+0x18a5
[k:\windows-openib\src\winib-467b\core\al\kernel\al_smi.c @ 718]
f7926c78 ba969a45 ibbus!spl_qp_agent_pnp+0x128
[k:\windows-openib\src\winib-467b\core\al\kernel\al_smi.c @ 476]
f7926c8c ba98f071 ibbus!spl_qp0_agent_pnp_cb+0x95
[k:\windows-openib\src\winib-467b\core\al\kernel\al_smi.c @ 429]
f7926cf4 ba98f2e8 ibbus!__pnp_notify_user+0x561
[k:\windows-openib\src\winib-467b\core\al\kernel\al_pnp.c @ 523]
f7926d38 ba990e7c ibbus!__pnp_port_notify+0x118
[k:\windows-openib\src\winib-467b\core\al\kernel\al_pnp.c @ 612]
f7926d70 ba94d8a4 ibbus!__pnp_process_add_ca+0x2dc
[k:\windows-openib\src\winib-467b\core\al\kernel\al_pnp.c @ 943]
f7926d8c ba953b94 ibbus!__cl_async_proc_worker+0x94
[k:\windows-openib\src\winib-467b\core\complib\cl_async_proc.c @ 153]
f7926da0 ba955c4c ibbus!__cl_thread_pool_routine+0x54
[k:\windows-openib\src\winib-467b\core\complib\cl_threadpool.c @ 67]
f7926dac 80a07678 ibbus!__thread_callback+0x2c
[k:\windows-openib\src\winib-467b\core\complib\kernel\cl_thread.c @ 49]
f7926ddc 80781346 nt!PspSystemThreadStartup+0x2e
00000000 00000000 nt!KiThreadStartup+0x16
0: kd> g




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.