[openib-general] OpenSM/osm_log API: Use symbol versions rather than polluting namespace

[Hal Rosenstock]

On Wed, 2006-09-06 at 09:42, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > Subject: OpenSM/osm_log API: Use symbol versions rather than polluting namespace
> > 
> > OpenSM/osm_log API: Rather than polluting the namespace with needless
> > symbols, use symbol versions and have a versioned osm_log_init rather
> > than adding osm_log_init_v2 as an additional API
> > 
> > This patch is intended to be applied to both trunk and 1.1 versions.
> > 
> > Signed-off-by: Doug Ledford <dledford at redhat.com>
> > Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> 
> This preserves the ABI, but would this not break the API?

Yes, this patch changes the API (in a most trivial way).

> Anyway, frankly, I do not see why was osm_log_init_v2 added into 1.1 at all.
> We are in code freeze, only critical fixes are supposed to be applied to branch
> at this stage. How was adding osm_log_init_v2 critical?

There was a bug reported when the log filled up which started motivating
these changes. We had just missed the rc3 window for this. It is an
upward compatible change so is low risk.

> Nor is this feature uncontroversial. Would not support for log rotation
> be better?

Were there comments on the list before to this effect ?

> So - why are all these changes going into 1.1 branch?

See answers above.

-- Hal