[openib-general] OpenSM/osm_log API: Use symbol versions rather than polluting namespace

[Doug Ledford]

On Wed, 2006-09-06 at 18:16 +0300, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > Subject: Re: OpenSM/osm_log API: Use symbol versions rather than polluting namespace
> > 
> > On Wed, 2006-09-06 at 09:42, Michael S. Tsirkin wrote:
> > > Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > > > Subject: OpenSM/osm_log API: Use symbol versions rather than polluting namespace
> > > > 
> > > > OpenSM/osm_log API: Rather than polluting the namespace with needless
> > > > symbols, use symbol versions and have a versioned osm_log_init rather
> > > > than adding osm_log_init_v2 as an additional API
> > > > 
> > > > This patch is intended to be applied to both trunk and 1.1 versions.
> > > > 
> > > > Signed-off-by: Doug Ledford <dledford at redhat.com>
> > > > Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> > > 
> > > This preserves the ABI, but would this not break the API?
> > 
> > Yes, this patch changes the API (in a most trivial way).
> 
> So all users need to change code or they won't compile against the new
> library?

Yes, and that is the correct way to handle this change.  I could see
leaving the whole log init change out entirely, but if it's going to go
in, this is the right way to do it.

> Not sure what do you mean by upward compatible. This API change does not seem to
> be backward compatible - won't it break building dependent applications?
> If so is not something you should do after code freeze.

APIs change.  Any app you can build can compensate.  The goal is to keep
apps that aren't recompiled working, and to make apps that are
recompiled compliant with the latest version of the function.


-- 
Doug Ledford <dledford at redhat.com>
              GPG KeyID: CFBFF194
              http://people.redhat.com/dledford

Infiniband specific RPMs available at
              http://people.redhat.com/dledford/Infiniband
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20060907/ae9c10e7/attachment.sig>