[openib-general] [PATCH 2/13] osm: port to WinIB stack : include/opensm/osm_pkey.h

Hal Rosenstock halr at voltaire.com
Mon Sep 18 03:53:51 PDT 2006


Hi Eitan,

On Sun, 2006-09-17 at 11:58, Eitan Zahavi wrote:
> Hi Hal
> 
> Partition tables blocks are always 16 bits. 
> This resolves the need to later cast back and forth.
> 
> Thanks
> 
> Eitan
> 
> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>
> 
> Index: include/opensm/osm_pkey.h
> ===================================================================
> --- include/opensm/osm_pkey.h	(revision 9502)
> +++ include/opensm/osm_pkey.h	(working copy)
> @@ -143,7 +143,7 @@ typedef struct _osm_pkey_tbl
>  typedef struct _osm_pending_pkey {
>    cl_list_item_t	list_item;
>    uint16_t		pkey;
> -  uint32_t		block;
> +  uint16_t		block;
>    uint8_t		index;
>    boolean_t		is_new;
>  } osm_pending_pkey_t;
> @@ -396,7 +396,7 @@ ib_api_status_t
>  osm_pkey_tbl_get_block_and_idx(
>    IN  osm_pkey_tbl_t *p_pkey_tbl, 
>    IN  uint16_t       *p_pkey,
> -  OUT uint32_t       *block_idx,
> +  OUT uint16_t       *block_idx,
>    OUT uint8_t        *pkey_index);
>  /*
>  *  p_pkey_tbl

Doesn't this require at least a similar change to
opensm/osm_pkey.c:osm_pkey_tbl_get_block_and_idx ? Anything else ?

-- Hal





More information about the general mailing list