[openib-general] [PATCH] IB/iser: fix iSER description and selections in Kconfig

[Roland Dreier]

    Erez> There are 3 additional required config entries: NET, INET &
    Erez> INFINIBAND_RDMA_CM. Do you suggest to 'depned' on them or
    Erez> 'depned' on some of them and 'select' the rest?

INET depends on NET, and INFINIBAND_RDMA_CM doesn't exist.  So
depending on INET is sufficient.  That's the reason 'depend' is better
than 'select' -- you don't have to worry about recreating the full
dependency tree of things you depend on.

    Erez> Also, since I'm not familiar enough with 'make rndconfig',
    Erez> here's a question: if iSER 'depends' on INET, is it possible
    Erez> that 'make rndconfig' will enable iSER without enabling
    Erez> INET?

No, of course not.  The whole point of make randconfig is to make a
random but valid configuration.

Anyway, rather than waste more time going back and forth on this, I
added the following to my for-2.6.19 tree as the obvious fix:

Author: Roland Dreier <rolandd at cisco.com>
Date:   Sun Sep 17 22:58:27 2006 -0700

    IB/iser: INFINIBAND_ISER depends on INET
    
    iSER won't build without CONFIG_INET enabled, so make Kconfig reflect that.
    
    Signed-off-by: Roland Dreier <rolandd at cisco.com>

diff --git a/drivers/infiniband/ulp/iser/Kconfig b/drivers/infiniband/ulp/iser/Kconfig
index fead87d..365a1b5 100644
--- a/drivers/infiniband/ulp/iser/Kconfig
+++ b/drivers/infiniband/ulp/iser/Kconfig
@@ -1,6 +1,6 @@
 config INFINIBAND_ISER
 	tristate "ISCSI RDMA Protocol"
-	depends on INFINIBAND && SCSI
+	depends on INFINIBAND && SCSI && INET
 	select SCSI_ISCSI_ATTRS
 	---help---
 	  Support for the ISCSI RDMA Protocol over InfiniBand.  This