[openib-general] [PATCH] osm: bug in OpenSM on broken fabrics

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Mon Sep 18 11:52:09 PDT 2006


Hi Hal

This patch fixes a bug in opensm that was discovered on
a 'broken' fabrics when opensm was executed with --stay_on_fatal.
Replacing assert with a real check.

Yevgeny

Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>

Index: opensm/osm_node_info_rcv.c
===================================================================
--- opensm/osm_node_info_rcv.c  (revision 9527)
+++ opensm/osm_node_info_rcv.c  (working copy)
@@ -543,7 +543,13 @@ __osm_ni_rcv_process_ca_port(
      p_physp = osm_node_get_physp_ptr( p_node, port_num );

      CL_ASSERT( p_physp );
-    CL_ASSERT( osm_physp_is_valid( p_physp ) );
+    if (!osm_physp_is_valid( p_physp ))
+    {
+        osm_log( p_rcv->p_log, OSM_LOG_ERROR,
+                 "__osm_ni_rcv_process_ca_port: ERR 0D19: "
+                 "Invalid physical port found. Aborting discovery.\n");
+        goto Exit;
+    }

      /*
        Update the DR Path to the port,






More information about the general mailing list