[openib-general] [PATCH] IB/sa: fix ib_sa_selector names
Michael S. Tsirkin
mst at mellanox.co.il
Mon Sep 18 20:03:41 PDT 2006
Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] IB/sa: fix ib_sa_selector names
>
> BTW, I think this means your original IPoIB patch that did:
>
> > + path->pathrec.mtu = priv->broadcast->mcmember.mtu;
> > + path->pathrec.mtu_selector = IB_SA_GTE;
>
> now needs to do something like
>
> + path->pathrec.mtu = max(IB_MTU_256, priv->broadcast->mcmember.mtu - 1);
> + path->pathrec.mtu_selector = IB_SA_GT;
>
> right?
>
> The strict inequality semantics defined by the spec are somewhat more
> awkward to actually use :(
But they also happen to work :).
I'm testing that patch and will post it RSN.
--
MST
More information about the general
mailing list