[openib-general] [PATCH] mthca: fix lid used for sending traps
Michael S. Tsirkin
mst at mellanox.co.il
Tue Sep 19 01:13:24 PDT 2006
From: "Jack Morgenstein" <jackm at dev.mellanox.co.il>
SM lid was incorrectly set to port lid. This is a regression from 2.6.17 -
after event, no traps are sent to the SM LID - they go to the
loopback interface instead, and are typicaly dropped there.
Should be set to sm_lid of port info response.
Signed-off-by: Jack Morgenstein <jackm at dev.mellanox.co.il>
Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
---
Roland, this fixes a serious regression from 2.6.17.
The bug was introduced by commit 12bbb2b7be7f5564952ebe0196623e97464b8ac5:
IB/mthca: Add client reregister event generation
I'm taking the fix into OFED 1.1 and I think it should go into 2.6.18 or
2.6.18.1.
Index: ofed_1_1/drivers/infiniband/hw/mthca/mthca_mad.c
===================================================================
--- ofed_1_1.orig/drivers/infiniband/hw/mthca/mthca_mad.c 2006-08-16 10:16:19.000000000 +0300
+++ ofed_1_1/drivers/infiniband/hw/mthca/mthca_mad.c 2006-09-19 10:33:31.280328000 +0300
@@ -119,7 +119,7 @@ static void smp_snoop(struct ib_device *
mthca_update_rate(to_mdev(ibdev), port_num);
update_sm_ah(to_mdev(ibdev), port_num,
- be16_to_cpu(pinfo->lid),
+ be16_to_cpu(pinfo->sm_lid),
pinfo->neighbormtu_mastersmsl & 0xf);
event.device = ibdev;
--
MST
More information about the general
mailing list