[openib-general] [PATCH 2/13] osm: port to WinIB stack : opensm/osm_subnet.c

Hal Rosenstock halr at voltaire.com
Tue Sep 19 10:28:38 PDT 2006


Hi Eitan,

On Sun, 2006-09-17 at 11:59, Eitan Zahavi wrote:
> Hi Hal

I think this patch is really 5/13 rather than 2/13.

> No need for stdio.h but do need stdlib.h ...

It appears to be the other way around (stdio.h needed but stdlib.h
isn't), right ?

> Also map snprintf to _snprintf in windows case
> 
> Thanks
> 
> Eitan
> 
> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>
> 
> Index: opensm/osm_subnet.c
> ===================================================================
> --- opensm/osm_subnet.c	(revision 9502)
> +++ opensm/osm_subnet.c	(working copy)
> @@ -53,6 +53,7 @@
>  
>  #include <stdlib.h>

Should this include of stdlib.h also be removed ?

-- Hal

>  #include <string.h>
> +#include <stdio.h>
>  #include <complib/cl_debug.h>
>  #include <opensm/osm_subnet.h>
>  #include <opensm/osm_opensm.h>
> @@ -65,7 +66,6 @@
>  #include <opensm/osm_node.h>
>  #include <opensm/osm_multicast.h>
>  #include <opensm/osm_inform.h>
> -#include <stdlib.h>
>  
>  /**********************************************************************
>   **********************************************************************/
> @@ -659,6 +659,9 @@ __osm_subn_opts_unpack_charp(
>    }
>  }
>  
> +#ifdef WIN32
> +#define snprintf _snprintf
> +#endif
>  /**********************************************************************
>   **********************************************************************/
>  static void
> 





More information about the general mailing list