[openib-general] gen2_basic patch boogum?

[Dotan Barak]

Robert Walsh wrote:
> Another quick question: I noticed that in the latest changes your
> pushed, including my patches, you removed the following check in test_qp.c:
>
> @@ -1702,7 +1700,6 @@
>                 CHECK_VALUE("qp_type", query_init_attr.qp_type,
> attr.qp_type, goto cleanup);
>                 CHECK_VALUE_PTR("recv_cq", query_init_attr.recv_cq,
> attr.recv_cq, goto cleanup);
>                 CHECK_VALUE_PTR("send_cq", query_init_attr.send_cq,
> attr.send_cq, goto cleanup);
> -               CHECK_VALUE("sq_sig_all", query_init_attr.sq_sig_all,
> attr.sq_sig_all, goto cleanup);
>                 CHECK_VALUE_PTR("srq", query_init_attr.srq, attr.srq,
> goto cleanup);
>         }
>         PASSED;
>
> Any particular reason why you removed this?  I don't ever remember this
> being a problem on ipath or mthca.
>
> Regards,
>  Robert.
>   
Yes, in the IB spec, the query QP don't have to return the signal type 
of the SQ.
so, i prefer not to check an attribute that is not mandatory.

Dotan