[openib-general] [PATCH] IB/ipoib: NAPI
Roland Dreier
rdreier at cisco.com
Mon Sep 25 11:58:43 PDT 2006
> I just find a flag + conditional peek a much simpler approach.
> Since all our testing is done on mthca anyway, almost
> all approaches amount to doing a NOP in various ways for us.
Umm, that's a pretty parochial attitude...
> So I would suggest
> - get Eli's patch with simple flag into shape & working on all hardware,
> push into git.
> - people interested in specific hardware test performance and propose patches
> to improve it even further.
What is a 'simple flag'? Who is going to implement peek_cq() for ehca
and ipath?
I'm not really that interested in the most micro-optimized approach.
I'd rather have something simple and easy to maintain -- in other
words, I don't want 2 or 3 completion handling paths in IPoIB. And
from that perspective, extending req_notify_cq() looks pretty good to
me.
- R.
More information about the general
mailing list