[ofa-general] Re: re [NET]: Fix neighbour destructor handling

[Michael S. Tsirkin]

> I did followed most of the discussions between you and MoniS re the 
> ipoib/bonding integration in OFED 1.2 and elsewhere, however: i don't 
> see why "bonding is basically broken for ipoib", if you don't mind, 
> please tell me the bottom line from your perspective.

Here's a short summary of issues I saw last time, I'm not sure
I haven't forgot something but here goes:

1.Calling to_ipoib_neigh without device lock taken might be racy
  I think you need to find another way to find the device.
2.Ah kept in the ipoib_neigh might belong to a device which is different
  from the one start_xmit is called at.
3.When the slave device goes down, master does not, and since
  neighbours are matched to the master there's no guarantee they will be
  cleaned up.
4.Bonding module copies a pointer to the cleanup function in a manner
  that is unsafe if ipoib is built as a module.

I think these need to be addressed somehow before the patch's reposted.
 
-- 
MST