[ofa-general] Re: [RFC] [PATCH 1/3] 2.6.22 or 23 ib/sa: add registration for sa events

[Hal Rosenstock]

On Thu, 2007-04-19 at 20:03, Sean Hefty wrote:
> IB/sa: Add InformInfo/Notice support.
> 
> From: Sean Hefty <sean.hefty at intel.com>

[snip...]

> diff --git a/include/rdma/ib_sa.h b/include/rdma/ib_sa.h
> index 5e26b2f..46b52fd 100644
> --- a/include/rdma/ib_sa.h
> +++ b/include/rdma/ib_sa.h
> @@ -254,6 +254,126 @@ struct ib_sa_service_rec {
>  	u64		data64[2];
>  };
>  
> +enum {
> +	IB_SA_EVENT_TYPE_FATAL		= 0x0,
> +	IB_SA_EVENT_TYPE_URGENT		= 0x1,
> +	IB_SA_EVENT_TYPE_SECURITY	= 0x2,
> +	IB_SA_EVENT_TYPE_SM		= 0x3,
> +	IB_SA_EVENT_TYPE_INFO		= 0x4,
> +	IB_SA_EVENT_TYPE_EMPTY		= 0x7F,
> +	IB_SA_EVENT_TYPE_ALL		= 0xFFFF
> +};
> +
> +enum {
> +	IB_SA_EVENT_PRODUCER_TYPE_CA		= 0x1,
> +	IB_SA_EVENT_PRODUCER_TYPE_SWITCH	= 0x2,
> +	IB_SA_EVENT_PRODUCER_TYPE_ROUTER	= 0x3,
> +	IB_SA_EVENT_PRODUCER_TYPE_CLASS_MANAGER	= 0x4,
> +	IB_SA_EVENT_PRODUCER_TYPE_ALL		= 0xFFFFFF
> +};
> +
> +enum {
> +	IB_SA_SM_TRAP_GID_IN_SERVICE			= 64,
> +	IB_SA_SM_TRAP_GID_OUT_OF_SERVICE		= 65,
> +	IB_SA_SM_TRAP_CREATE_MC_GROUP			= 66,
> +	IB_SA_SM_TRAP_DELETE_MC_GROUP			= 67,
> +	IB_SA_SM_TRAP_PORT_CHANGE_STATE			= 128,
> +	IB_SA_SM_TRAP_LINK_INTEGRITY			= 129,
> +	IB_SA_SM_TRAP_EXCESSIVE_BUFFER_OVERRUN		= 130,
> +	IB_SA_SM_TRAP_FLOW_CONTROL_UPDATE_EXPIRED	= 131,
> +	IB_SA_SM_TRAP_BAD_M_KEY				= 256,
> +	IB_SA_SM_TRAP_BAD_P_KEY				= 257,
> +	IB_SA_SM_TRAP_BAD_Q_KEY				= 258,
> +	IB_SA_SM_TRAP_ALL				= 0xFFFF
> +};

Just a nit question:

Any reason trap 259 was omitted here ?

-- Hal

[snip...]