[ofa-general] Re: [RFC/PATCH] mthca: ensure alignment of doorbell writes
Roland Dreier
rdreier at cisco.com
Fri Aug 3 14:26:52 PDT 2007
> What do you think about using the new
> "doorbell type" that was in the patch that started
> this thread? For mthca it was defined like this:
>
> union mthca_doorbell {
> __be64 val64;
> __be32 val32[2];
> };
>
> Or should we just add __attribute__ ((aligned(8))) to
> all the "__be32 doorbell[2]", etc. definitions?
I was going to investigate how the assembly comes out if we just make
these doorbell values be __be64, in particular on i386 and also ia64.
But maybe the union is a good solution too.
- R.
More information about the general
mailing list