[ofa-general] Re: [PATCH 3/4] opensm: resweep instead of exit when duplicated guid suspected

[Hal Rosenstock]

On 8/12/07, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> Anyway OpenSM will request resweep when there are suspected nodes
> with duplicate GUID on the subnet. And because we cannot be 100% sure
> that detected GUIDs duplication is not some corner case of port moving
> I prefer to not exit. Endless (re)discovery and syslog messages should
> be good indication if it is indeed this case.

Couldn't there be some duplication state kept per GUID so the messages
only get logged on change of state to duplicated rather than
continually spewing into the log ?

>
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
>  opensm/opensm/osm_node_info_rcv.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/opensm/opensm/osm_node_info_rcv.c b/opensm/opensm/osm_node_info_rcv.c
> index 715c0f4..ae95964 100644
> --- a/opensm/opensm/osm_node_info_rcv.c
> +++ b/opensm/opensm/osm_node_info_rcv.c
> @@ -129,12 +129,6 @@ report_duplicated_guid(
>
>   osm_log( p_rcv->p_log, OSM_LOG_SYS,
>            "FATAL: duplicated guids or 12x lane reversal\n");
> -
> -  if ( p_rcv->p_subn->opt.exit_on_fatal == TRUE )
> -  {
> -    osm_log( p_rcv->p_log, OSM_LOG_SYS, "Exiting\n");
> -    exit( 1 );
> -  }
>  }
>
>  static void requery_dup_node_info(
> --
> 1.5.3.rc2.38.g11308
>
>