[ofa-general] [PATCH] mlx4_ib QP max msg size
Roland Dreier
rdreier at cisco.com
Tue Aug 14 21:22:46 PDT 2007
This needs a better description -- a patch's changelog entry should
explain why we want to make a change, what the change does and why it
fixes/improves whatever the issue is. For this patch I don't
understand why we want to make these changes.
> - if (ibqp->qp_type == IB_QPT_GSI || ibqp->qp_type == IB_QPT_SMI ||
> - ibqp->qp_type == IB_QPT_UD)
> + if (ibqp->qp_type == IB_QPT_GSI || ibqp->qp_type == IB_QPT_SMI)
> + context->mtu_msgmax = (IB_MTU_4096 << 5) | 11;
> + else if (ibqp->qp_type == IB_QPT_UD)
> context->mtu_msgmax = (IB_MTU_4096 << 5) | 11;
This is especially mysterious: you seem to have changed
if (A || B || C)
foo();
into
if (A || B)
foo();
else if (C)
foo();
which seems to be exactly equivalent code.
More information about the general
mailing list