[ofa-general] Re: [PATCH] ipoib - scatter/gather suopport

[Michael S. Tsirkin]

>  > -			.max_send_sge = 1,
>  > +			.max_send_sge = MAX_SKB_FRAGS + 1,
> 
> this makes WQEs much bigger -- do we want to do this for all devices?
> Or is it going to hurt on something like Tavor, which doesn't do
> checksum offload and hence can't take advantage of scatter/gather
> anyway?

Should be measured, but I would expect the cost to be negligeable.
And as was recently mentioned on this list, some users might want to use
ethtool to enable s/g even if the device does not support
checksum in hardware.

How about we disable s/g by default, and let the user enable it
with ethtool as appropriate?

-- 
MST