[ofa-general] Re: [PATCH 7/7 V3] osm: QoS - reading policy file

[Sasha Khapyorsky]

On 18:00 Tue 28 Aug     , Yevgeny Kliteynik wrote:
> >>  	}
> >>  	fclose(opts_file);
> >>
> >> +	/* read QoS policy config file */
> >> +	if (!p_subn->opt.no_qos)
> >> +		osm_qos_parse_policy_file(p_subn);
> >> +
> > Should the qos parser return value be checked and an error logged in
> > case of failure?
> 
>  The parser logs the errors (whether the policy file is not found, or there 
>  is
>  a syntax error, or any other error).
>  If some error occurred, the p_subn->p_qos_policy will be null.
>  Do you think I should add status checking here as well?
>  I think it would be redundant.

Ok.

Sasha