[ofa-general] [PATCH 6/7 V3] osm: QoS - compiling policy file parser

[Yevgeny Kliteynik]

Hal Rosenstock wrote:
> On 8/27/07, Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il> wrote:
>> Compiling QoS policy file parser.
> 
> Should there be an build enable for this functionality (like
> --enable-qos-policy) ? I expect that some will want to not include
> this. By default, this should be disabled IMO.

Do you mean that by default OpenSM should be configured and compiled
w/o the new QoS?
Why? Is it for reducing binary size?
If so, is it really the most common case of using OpenSM?

> BTW, what is the "level" of this QoS support for OFED 1.3 ? Is it
> technology preview ?

Yes, it's technology preview.

-- Yevgeny

> -- Hal
> 
>> C & H files are generated from Lex & Yacc files and the
>> generated files are compiled.
>> Generated files are not included in git, but they do get
>> included in RPM as they are also created by 'make dist'.
>> Generated files can be removed by "make maintainer-clean".
>>
>> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
>> ---
>>  opensm/include/Makefile.am |    2 ++
>>  opensm/opensm/Makefile.am  |   16 +++++++++++++++-
>>  opensm/opensm/configure.in |    2 ++
>>  3 files changed, 19 insertions(+), 1 deletions(-)
>>
>> diff --git a/opensm/include/Makefile.am b/opensm/include/Makefile.am
>> index ea62507..b83205f 100644
>> --- a/opensm/include/Makefile.am
>> +++ b/opensm/include/Makefile.am
>> @@ -90,6 +90,8 @@ EXTRA_DIST = \
>>        $(srcdir)/opensm/osm_state_mgr_ctrl.h \
>>        $(srcdir)/opensm/osm_perfmgr.h \
>>        $(srcdir)/opensm/osm_perfmgr_db.h \
>> +       $(srcdir)/opensm/osm_qos_policy.h \
>> +       $(srcdir)/opensm/osm_qos_parser_y.h \
>>        $(srcdir)/complib/cl_thread_osd.h \
>>        $(srcdir)/complib/cl_packon.h \
>>        $(srcdir)/complib/cl_atomic_osd.h \
>> diff --git a/opensm/opensm/Makefile.am b/opensm/opensm/Makefile.am
>> index 6dfa824..9d57f93 100644
>> --- a/opensm/opensm/Makefile.am
>> +++ b/opensm/opensm/Makefile.am
>> @@ -56,7 +56,15 @@ opensm_SOURCES = main.c osm_console.c osm_db_files.c \
>>                 osm_ucast_lash.c osm_ucast_file.c osm_ucast_ftree.c \
>>                 osm_vl15intf.c osm_vl_arb_rcv.c \
>>                 st.c osm_perfmgr.c osm_perfmgr_db.c \
>> -                osm_event_plugin.c osm_dump.c
>> +                osm_event_plugin.c osm_dump.c \
>> +                osm_qos_parser_y.c osm_qos_parser_l.c osm_qos_policy.c
>> +
>> +osm_qos_parser_y.c: $(srcdir)/osm_qos_parser.y $(srcdir)/../include/opensm/osm_qos_policy.h
>> +       $(YACC) -y -d $(srcdir)/osm_qos_parser.y -o $(srcdir)/osm_qos_parser_y.c --defines=$(srcdir)/../include/opensm/osm_qos_parser_y.h --name-prefix=__qos_parser_
>> +
>> +osm_qos_parser_l.c: $(srcdir)/osm_qos_parser.l $(srcdir)/../include/opensm/osm_qos_policy.h
>> +       $(LEX) --prefix=__qos_parser_ -o $(srcdir)/osm_qos_parser_l.c $(srcdir)/osm_qos_parser.l
>> +
>>  if OSMV_OPENIB
>>  opensm_CFLAGS = -Wall $(OSMV_CFLAGS) -fno-strict-aliasing -DVENDOR_RMPP_SUPPORT -DDUAL_SIDED_RMPP $(DBGFLAGS) -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1
>>  opensm_CXXFLAGS = -Wall $(OSMV_CFLAGS) -DVENDOR_RMPP_SUPPORT -DDUAL_SIDED_RMPP $(DBGFLAGS) -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1
>> @@ -104,3 +112,9 @@ install-exec-hook:
>>        if test -L $(DESTDIR)/$(libdir)/libopensm-$(VERSION).so; then rm $(DESTDIR)/$(libdir)/libopensm-$(VERSION).so; fi; \
>>        lname=`\ls -l $(DESTDIR)/$(libdir)/libopensm.so | awk '{print $$NF}'`; \
>>        ln -s $$lname $(DESTDIR)/$(libdir)/libopensm-$(VERSION).so
>> +
>> +# generate c and h files from the lex and yacc files
>> +dist-hook: $(srcdir)/osm_qos_parser_y.c $(srcdir)/osm_qos_parser_l.c
>> +
>> +maintainer-clean-generic:
>> +       rm -f $(srcdir)/osm_qos_parser_y.c $(srcdir)/osm_qos_parser_l.c
>> diff --git a/opensm/opensm/configure.in b/opensm/opensm/configure.in
>> index afb20b3..a49538d 100644
>> --- a/opensm/opensm/configure.in
>> +++ b/opensm/opensm/configure.in
>> @@ -22,6 +22,8 @@ AC_PROG_INSTALL
>>  AC_PROG_LN_S
>>  AC_PROG_MAKE_SET
>>  AC_PROG_LIBTOOL
>> +AM_PROG_LEX
>> +AC_PROG_YACC
>>
>>  dnl Checks for libraries
>>
>> --
>> 1.5.1.4
>>
>> _______________________________________________
>> general mailing list
>> general at lists.openfabrics.org
>> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>>
>> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>>
>