[ofa-general] Re: [PATCH] Export ehca module parameters in sysfs

[Hoang-Nam Nguyen]

Hi Anton,
Thanks for this catch.
Nam

Acked-by: Hoang-Nam Nguyen <hnguyen at de.ibm.com>

>
> Hi,
>
> At the moment the ehca module parameters are not exported in sysfs.
> Export them with 0444 permissions.
>
> Signed-off-by: Anton Blanchard <anton at samba.org>
> ---
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
> b/drivers/infiniband/hw/ehca/ehca_main.c
> index 99036b6..db041df 100644
> --- a/drivers/infiniband/hw/ehca/ehca_main.c
> +++ b/drivers/infiniband/hw/ehca/ehca_main.c
> @@ -65,16 +65,16 @@ int ehca_static_rate   = -1;
>  int ehca_scaling_code  = 0;
>  int ehca_mr_largepage  = 0;
>
> -module_param_named(open_aqp1,     ehca_open_aqp1,     int, 0);
> -module_param_named(debug_level,   ehca_debug_level,   int, 0);
> -module_param_named(hw_level,      ehca_hw_level,      int, 0);
> -module_param_named(nr_ports,      ehca_nr_ports,      int, 0);
> -module_param_named(use_hp_mr,     ehca_use_hp_mr,     int, 0);
> -module_param_named(port_act_time, ehca_port_act_time, int, 0);
> -module_param_named(poll_all_eqs,  ehca_poll_all_eqs,  int, 0);
> -module_param_named(static_rate,   ehca_static_rate,   int, 0);
> -module_param_named(scaling_code,  ehca_scaling_code,  int, 0);
> -module_param_named(mr_largepage,  ehca_mr_largepage,  int, 0);
> +module_param_named(open_aqp1,     ehca_open_aqp1,     int, S_IRUGO);
> +module_param_named(debug_level,   ehca_debug_level,   int, S_IRUGO);
> +module_param_named(hw_level,      ehca_hw_level,      int, S_IRUGO);
> +module_param_named(nr_ports,      ehca_nr_ports,      int, S_IRUGO);
> +module_param_named(use_hp_mr,     ehca_use_hp_mr,     int, S_IRUGO);
> +module_param_named(port_act_time, ehca_port_act_time, int, S_IRUGO);
> +module_param_named(poll_all_eqs,  ehca_poll_all_eqs,  int, S_IRUGO);
> +module_param_named(static_rate,   ehca_static_rate,   int, S_IRUGO);
> +module_param_named(scaling_code,  ehca_scaling_code,  int, S_IRUGO);
> +module_param_named(mr_largepage,  ehca_mr_largepage,  int, S_IRUGO);
>
>  MODULE_PARM_DESC(open_aqp1,
>         "AQP1 on startup (0: no (default), 1: yes)");