[ofa-general] Re: [PATCH] Quieten some error messages in ehca

[Hoang-Nam Nguyen]

Thanks
Nam

Acked-by: Hoang-Nam Nguyen <hnguyen at de.ibm.com>

Anton Blanchard <anton at samba.org> wrote on 29.08.2007 18:05:35:

>
> Hi,
>
> ehca spits out a lot of debugging information. I had to look closely to
> see the "Port 1 is not active" message within all the debug:
>
> eHCA Infiniband Device Driver (Rel.: SVNEHCA_0022)
> eHCA scaling code enabled
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_define_sqp Port 1 is
> not active.
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_create_qp
> ehca_define_sqp() failed rc=ffffffffffffffff
> ib_mad: Couldn't create ib_mad QP1
> ib_mad: Couldn't open ehca0 port 1
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_alloc_fmr unsupported
> fmr_attr->page_shift=9
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_alloc_fmr
> rc=ffffffffffffffea pd=c000000b4b5b2420 mr_access_flags=7
> fmr_attr=c0000005afd37394
> fmr_create failed for FMR 0
>
> Remove a few debug statements so that things are clearer:
>
> eHCA Infiniband Device Driver (Rel.: SVNEHCA_0022)
> eHCA scaling code enabled
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_define_sqp Port 1 is
> not active.
> ib_mad: Couldn't create ib_mad QP1
> ib_mad: Couldn't open ehca0 port 1
> ehca D.001.DQDXYCB-P1-C9: PU0006 EHCA_ERR:ehca_alloc_fmr unsupported
> fmr_attr->page_shift=9
> fmr_create failed for FMR 0
>
> Signed-off-by: Anton Blanchard <anton at samba.org>
> ---
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
> b/drivers/infiniband/hw/ehca/ehca_mrmw.c
> index c1b868b..57e3420 100644
> --- a/drivers/infiniband/hw/ehca/ehca_mrmw.c
> +++ b/drivers/infiniband/hw/ehca/ehca_mrmw.c
> @@ -848,10 +848,6 @@ struct ib_fmr *ehca_alloc_fmr(struct ib_pd *pd,
>  alloc_fmr_exit1:
>     ehca_mr_delete(e_fmr);
>  alloc_fmr_exit0:
> -   if (IS_ERR(ib_fmr))
> -      ehca_err(pd->device, "rc=%lx pd=%p mr_access_flags=%x "
> -          "fmr_attr=%p", PTR_ERR(ib_fmr), pd,
> -          mr_access_flags, fmr_attr);
>     return ib_fmr;
>  } /* end ehca_alloc_fmr() */
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
> b/drivers/infiniband/hw/ehca/ehca_qp.c
> index b178cba..448f6b3 100644
> --- a/drivers/infiniband/hw/ehca/ehca_qp.c
> +++ b/drivers/infiniband/hw/ehca/ehca_qp.c
> @@ -712,8 +712,6 @@ static struct ehca_qp *internal_create_qp(
>     if (qp_type == IB_QPT_GSI) {
>        h_ret = ehca_define_sqp(shca, my_qp, init_attr);
>        if (h_ret != H_SUCCESS) {
> -         ehca_err(pd->device, "ehca_define_sqp() failed rc=%lx",
> -             h_ret);
>           ret = ehca2ib_return_code(h_ret);
>           goto create_qp_exit4;
>        }
>