[ofa-general] Re: [PATCH] osm: QoS parser - fixing yacc command

[Ira Weiny]

We just ran into a problem with this patch applied.

It seems that the output file is not y.tab.h but osm_qos_parser_y.h so should
the move be: mv -f osm_qos_parser_y.h $(srcdir)/../include/opensm/osm_qos_parser_y.h

??

weiny2 at woprjr0:~/OpenIB/git-trees/management/opensm/opensm
15:51:42 > ls *.h
ls: *.h: No such file or directory

weiny2 at woprjr0:~/OpenIB/git-trees/management/opensm/opensm
15:52:02 > bison -d -o ./osm_qos_parser_y.c -p__qos_parser_ ./osm_qos_parser.y

weiny2 at woprjr0:~/OpenIB/git-trees/management/opensm/opensm
15:52:21 > ls *.h
osm_qos_parser_y.h

weiny2 at woprjr0:~/OpenIB/git-trees/management/opensm/opensm
15:53:17 > bison --version
bison (GNU Bison) 1.875c
Written by Robert Corbett and Richard Stallman.

Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.



On Sat, 01 Sep 2007 00:55:27 +0300
Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il> wrote:

> Sasha Khapyorsky wrote:
> > On 18:39 Thu 30 Aug     , Yevgeny Kliteynik wrote:
> >> Fixing bison command to more general yacc syntax
> >>
> >> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> > 
> > Applied. Thanks.
> > 
> >> ---
> >>  opensm/opensm/Makefile.am |    3 ++-
> >>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/opensm/opensm/Makefile.am b/opensm/opensm/Makefile.am
> >> index abfa913..4ab7227 100644
> >> --- a/opensm/opensm/Makefile.am
> >> +++ b/opensm/opensm/Makefile.am
> >> @@ -60,7 +60,8 @@ opensm_SOURCES = main.c osm_console.c osm_db_files.c \
> >>  		 osm_qos_parser_y.c osm_qos_parser_l.c osm_qos_policy.c
> >>
> >>  osm_qos_parser_y.c: $(srcdir)/osm_qos_parser.y $(srcdir)/../include/opensm/osm_qos_policy.h
> >> -	$(YACC) -y -d $(srcdir)/osm_qos_parser.y -o $(srcdir)/osm_qos_parser_y.c --defines=$(srcdir)/../include/opensm/osm_qos_parser_y.h --name-prefix=__qos_parser_
> >> +	$(YACC) -d -o $(srcdir)/osm_qos_parser_y.c -p__qos_parser_ $(srcdir)/osm_qos_parser.y
> >> +	mv -f y.tab.h $(srcdir)/../include/opensm/osm_qos_parser_y.h
> > 
> > BTW if osm_qos_parser_y.h file is generated one and used only by
> > generated *.c files is not it would be simpler just to lease it in
> > current directory?
> 
> Perhaps, but then it would be the only header file in opensm
> source that's not located under the include/ directory.
> Is it the only header that isn't included by other headers in osm?
> 
> -- Yevgeny
> 
> > Sasha
> > 
> 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general