[ofa-general] [PATCH 1/2] uDAT/uDAPL v2 - (master branch) changes to sync common code base with WinOF 1.01

[James Lentini]

On Fri, 7 Dec 2007, Arlin Davis wrote:

> James,
> 
> Please review patch series to bring in latest WinOF code base into the mainstream. I would like to
> keep the commond code base from diverging as much as possible. This is a pretty straight forward
> change but it touches alot of files. This is on master branch (now based on a v2 code base) and is
> not targeted for OFED 1.3.
> 
> 1/1 uDAT changes.
> 1/2 uDAPL changes.
> 
>   - add DAT_API to specify calling conventions (windows=__stdcall, linux= ) 
>   - cleanup platform specific definitions for windows
>   - c++ support
> 
> Signed-off by: Arlin Davis <ardavis at ichips.intel.com>

Looks good Arlin. One very minor question:

> diff --git a/dat/common/dat_api.c b/dat/common/dat_api.c
> index 1415f73..a3d2274 100755
> --- a/dat/common/dat_api.c
> +++ b/dat/common/dat_api.c
<snip>
> @@ -334,7 +334,7 @@ DAT_RETURN dat_get_consumer_context (
>          DAT_IA_HANDLE   dapl_ia_handle;
>          DAT_RETURN      dat_status;
>  
> -        dat_status = dats_get_ia_handle((unsigned long)dat_handle,
> +        dat_status = dats_get_ia_handle((DAT_IA_HANDLE)dat_handle,
>                                          &dapl_ia_handle);
>  
>          /* failure to map the handle is unlikely but possible */
<snip>
> @@ -875,8 +874,7 @@ DAT_RETURN dat_lmr_sync_rdma_read(
>      DAT_IA_HANDLE	dapl_ia_handle;
>      DAT_RETURN		dat_status;
>  
> -    dat_status = dats_get_ia_handle((unsigned long)ia_handle,
> -				    &dapl_ia_handle);
> +    dat_status = dats_get_ia_handle(ia_handle, &dapl_ia_handle);

For consistency with your change above, should the cast 
be changed to 

+    dat_status = dats_get_ia_handle((DAT_IA_HANDLE)ia_handle, &dapl_ia_handle);

>      if (dat_status == DAT_SUCCESS)
>      {
>  	dat_status = DAT_LMR_SYNC_RDMA_READ (dapl_ia_handle,