[ofa-general] [PATCH 1/2 rev2] uDAT/uDAPL v2 - (master branch) changes to sync common code base with WinOF 1.01
James Lentini
jlentini at netapp.com
Tue Dec 11 13:57:59 PST 2007
On Tue, 11 Dec 2007, Arlin Davis wrote:
>
> >> - dat_status = dats_get_ia_handle((unsigned long)ia_handle,
> >> - &dapl_ia_handle);
> >> + dat_status = dats_get_ia_handle(ia_handle, &dapl_ia_handle);
> >
> >For consistency with your change above, should the cast
> >be changed to
> >
> >+ dat_status = dats_get_ia_handle((DAT_IA_HANDLE)ia_handle,
> >&dapl_ia_handle);
> >
>
> Good catch. I missed some dat_api.c changes from Stan. Here is rev2.
>
> - add DAT_API to specify calling conventions (windows=__stdcall, linux= )
> - cleanup platform specific definitions for windows
> - c++ support
> - add handle check macros DAT_IA_HANDLE_TO_UL and UL_TO_DAT_IA_HANDLE
For naming consistency, I'd suggest DAT_UL_TO_IA_HANDLE instead of
UL_TO_DAT_IA_HANDLE. I defer to your judgement on which to use.
Other than that, looks good.
More information about the general
mailing list