[ofa-general] [PATCH] [RFC] IPOIB/CM Enable SRQ support on HCAs with less than 16 SG entries

[Pradeep Satyanarayana]

Good points. I will incorporate your comments.

Roland Dreier wrote:
>  > +static int num_of_frags;
>  > +int max_cm_mtu;
> 
> I think these values need to be per-interface -- think of the case of
> a system with more than one type of HCA installed, where the different
> HCAs have different limits.
> 
>  > @@ -623,6 +626,7 @@ repost:
>  >  			--p->recv_count;
>  >  			ipoib_warn(priv, "ipoib_cm_post_receive_nonsrq failed "
>  >  				   "for buf %d\n", wr_id);
>  > +		kfree(mapping); /*** Check if this needed ***/
> 
> This looks really bogus -- I don't see anything in your patch that
> changes mapping from being allocated on the stack.

Right, as the comment illustrates it is a hold over from something else
and slipped into the patch.

Pradeep