[openib-general] [PATCH 00/12] ofed_1_2 - Neighbour update support

[Michael S. Tsirkin]

> Here are the backports for snooping arp packets to generate neighbour
> update netevents.

OK, I went (somewhat belatedly) over this code in more depth and I see
a couple of issues that I'd like you to address:

- There's some trailing whitespace in some netevet.c files.
  Could you clean these please?

- I see:
	$ diff ./kernel_addons/backport/2.6.9_U4/include/src/netevent.c
	kernel_addons/backport/2.6.5_sles9_sp3/include/src/netevent.c
	> #include <linux/skbuff.h>

Should not redhat backports include skbuff.h too?
They do use skbuff struct so it seems it is cleaner to include
directly, and we would get identical code for redhat and suse.
 
- What is the reason for:
        if ((op == ARPOP_REQUEST || op == ARPOP_REPLY) && !skb->destructor)
	                skb->destructor = destructor;

	kfree_skb(skb);

Could we miss events because skb has a desctructor?
Can we just call the descructor function directly (this is what addr.c
did previously, and this apparently worked fine).

Steve, could you pls clone ofed git and address these?


-- 
MST