[openib-general] [PATCH 00/12] ofed_1_2 - Neighbour update support

Michael S. Tsirkin mst at mellanox.co.il
Thu Feb 1 14:48:41 PST 2007


> > I can think of some more complicated approaches that might work better
> > for iwarp. Off the top of my head, our netevents implementation could
> > keep a reference on the skb, start a timer, check the users counter on skb and
> > call the notifier chain when it drops to 1. Let's sleep on it.
> > 
> 
> Ok.  I'll ponder it some more.  But we could solve the module unload
> issue via module refs methinks.

This almost never works cleanly - module can't reference itself
without races: module can get unloaded after it drops the reference
to itself and before the function exits.
But I agree such a race is mostly theoretical.

And we still have the case where destructor != NULL.

Certainly something to think about.

-- 
MST




More information about the general mailing list