[openib-general] IPoIB CM for merge?

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: IPoIB CM for merge?
> 
>  > Could you please spend some time reviewing IPoIB CM code?
>  > I am concerned about missing the 2.6.21 merge window.
> 
> Thanks for the reminder.
> 
> Can we trade?  Have you looked at the cxgb3 iwarp driver?  Any comments?

I haven't yet, sorry. OK.
I am not sure I have the last version posted so I am going to go by what
is there in OFED git tree.

And I also only looked under drivers/infiniband/.

So, here are some questions: I looked in the archives and have not seen
these addressed. Maybe these can be answered and then I'll go from there?
Does this sound OK?

Files with names like
./core/cxio_hal.c
./core/cxio_hal.h
normally generate a fair bit of discussion which wasn't present here,
I did not guess everyone was just busy.
For example, why is there both struct iwch_cq and struct t3_cq?

File tcb.h comment says:
/* This file is automatically generated --- do not edit */
This looks like a GPL violation, does it not?

What's the deal with the naming convention?
Is there a reason in cxgb3, some files start with iwch and some with cxio?
How about using cxgb3 prefix all over?

-- 
MST