[openib-general] [PATCHv6 RFC] IPoIB CM Experimental support

[Roland Dreier]

Looks pretty good, but one thing worries me:

Overall looks great, I'll merge it up.  A few quick questions: > +#ifdef CONFIG_IPV6

I think this really needs to be

#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

but I'm not clear on what happens if IPoIB is built-in and IPv6 is
built as a module, since then icmpv6_send() isn't available until the
ipv6 module is loaded.  It seems ip_gre.c has the same problem, so
I'll ask on netdev about this.

Also a few other minor things:

 > +#ifdef CONFIG_INFINIBAND_IPOIB_CM
 > +struct ib_cm_id;

this #ifdef in ipoib.h is just guarding declarations; we might as well
declare everything even if it's not used.

 > +	rep.starting_psn = 0 /* FIXME */;

any reason not to just do:

	rep.starting_psn = random32() & 0xffffff;

?

 > +	req.srq 	              = 15;

This just should be 1, right?


 - R.