[openib-general] more comments on cxgb3

Michael S. Tsirkin mst at mellanox.co.il
Thu Feb 8 07:34:10 PST 2007


> > - It seems that by passing in huge resource sizes, userspace will be able to
> >   drink up unlimited amounts of kernel memory.
> >   mthca handles this by using the mlock rlimit, should something be done here
> >   as well?
> 
> Hmm.  That's a good point.  I'll put this on the todo as well.  So mthca
> adds to process's rlimit value as things are allocated out of kernel
> memory (or maybe even anything that gets pinned)?

Yes. The code is actually in uverbs core, mthca uses that.

> > - I wonder about the names like get_mhp - what does "mhp" mean?
> > static inline struct iwch_mr *get_mhp(struct iwch_dev *rhp, u32 mmid)
> > {
> >         return idr_find(&rhp->mmidr, mmid);
> > }
> > 
> 
> Memory Handle Pointer.

hmm, what's a Handle? Maybe a better name can be found.

-- 
MST




More information about the general mailing list