[openib-general] [PATCH 0/5] iw_cxgb3 - misc cleanup and fixes

Michael S. Tsirkin mst at mellanox.co.il
Thu Feb 8 22:51:49 PST 2007


> > Also I agree with MST, I would like to see the core/ subdirectory die
> > completely.
> > 
> 
> ok ok...I'll kill the subdir...

It's not just the directory BTW. Stuff like building completions in
t3_cqe format and then reformatting to ib_wc seems to be much more confusing
(and some of it is actually on datapath).
Same goes for t3_wq and I suspect everything else defined in cxio_wr.h -
please, use the native types from include/rdma/.

Having to wade through 3 driver-specific layers of abstractions just because I want to
for example change API in ib_verbs.h and need to update all drivers will be
very taxing. I understand your design calls for 2 layers, but at least the API exposed
by code in drivers/net is fairly small, while cxio_wr.h declares 27 structures
which seem to just duplicate ib_verbs.h.

-- 
MST




More information about the general mailing list