[openib-general] [PATCH] RDMA/iwcm: Bugs in cm_conn_req_handler()

[Tom Tucker]

Kumar:

I _LOVE_ the patch and the fact that you're making this code better. I
just want to tweak it a little bit...

* Please convince yourself (and me ;-)) that the iw_cm_destroy_id can
never block where you've put it. I'll bet that it's fine, but convince
yourself too. Your comment scared me a little -- that's all.

* Please see if moving the call to reject can be moved to the destroy
switch so that we don't have to call it everywhere else.

* Please make sure that everywhere we call destory_cm_id, the cleanup of
the work queue is also done. 

Thanks,
Tom


On Fri, 2007-02-09 at 08:59 +0530, Krishna Kumar2 wrote:
> Roland,
> 
> Yes, we will do some "arm wrestling" today :)
> 
> thanks,
> 
>  KK
> 
> Roland Dreier <rdreier at cisco.com> wrote on 02/09/2007 05:20:42 AM:
> 
> > Hmm, Steve likes it, Tom doesn't.  Can you guys arm wrestle or
> > something and tell me if this patch is correct or not?
> >
> >  - R.
>