[openib-general] [PATCH][RFC] iw_cxgb3/2.6.21 - Don't use the physical address for mapping memory into userspace.

Steve Wise swise at opengridcomputing.com
Mon Feb 12 12:04:30 PST 2007


On Mon, 2007-02-12 at 11:58 -0800, Roland Dreier wrote:
> Looks mostly sane (assuming it works on 32-bit userspace on 64-bit
> kernel now), but:
> 
>  > -	context = kmalloc(sizeof(*context), GFP_KERNEL);
>  > +	context = kzalloc(sizeof(*context), GFP_KERNEL);
> 
> Why do you need this?  Is this an unrelated change?
> 

Because the key generator u32 is in the context now, and the kzalloc()
initializes it.  I could have done:  

context->key = 0;

But km -> kz was less typing. ;-)

Steve.





More information about the general mailing list