[openib-general] [PATCH] librdmacm: fix bug causing failure to work with partial membership pkey

[Hal Rosenstock]

On Wed, 2007-02-21 at 15:45, Or Gerlitz wrote:
> On 21 Feb 2007 08:20:23 -0500, Hal Rosenstock <halr at voltaire.com> wrote:
> > On Wed, 2007-02-21 at 07:35, Or Gerlitz wrote:
> 
> > > > I believe it is a spec (compliance) violation for the port to be a
> > > > partial member and join as a full member.
> 
> > > Since partial members can't talk among themselves, there is no reason to
> > > form a multicast group containing --only-- ports that can --not-- talk
> > > to each other... So if the spec does not allow this (having a partial
> > > member joining with the full member pkey) - it a spec bug...
> 
> > I think there are two issues here then:
> > 1. If this is the case, getting the spec changed to accomodate this use case
> > 2. I believe that OpenIB code is supposed to be spec compliant.
> 
> If the IPoIB spec does not allow both partial and full members of a
> partition to share a broadcast domain (eg the IPv4 broadcast group
> associated with the full membership pkey) or any other multicast
> group, burn it (or at least the relevant section).

I was referring to the IB spec, not an IPoIB RFC.

> The OpenIB code supposed to work and as done with the RDMA CM header,
> the implementation should not wait for spec to be written or changed.

Really ? Maybe I'm mistaken but I didn't think that OpenIB/OpenFabrics
wanted to issue code which is not IBA spec compliant.

-- Hal

> Or.