[openib-general] [PATCH 1/4] osm: TRIVIAL - making comparison functions static (fat-tree routing)

[Yevgeny Kliteynik]

Sasha Khapyorsky wrote:
> On 18:18 Tue 02 Jan     , Yevgeny Kliteynik wrote:
>> Sasha Khapyorsky wrote:
>>> Hi Yevgeny,
>>>
>>> On 15:30 Mon 01 Jan     , Yevgeny Kliteynik wrote:
>>>> Making two comparison functions in ftree static.
>>> Good.
>>>
>>> Any news about OSM_CDECL/__cdecl emilination?
>> Here's what I know by now:
>> __cdecl is default on windows, but osm is compiled with a flag
>> that makes __stdcall default (there are some problems linking
>> osm to other libraries without this flag),
> 
> Which problems? Isn't it better to solve those problems instead of such
> strange workaround as putting __cdecl/__stdcall attribution in the common
> code?

IB access layer on windows is compiled with __stdcall as default,
and there were problems linking opensm unless it also had the same
default.
I don't think I should invest too much time trying to figure out 
why IBAL should be compiled this way - I suppose there's a reason
for this.
Anyway, I'll check if the __stdcall can be removed (I'm sure it can, 
but need to check anyway)

-- Yevgeny.
 
>> so OSM_CDECL is gonna 
>> stay. One thing I do need to check is removing the __stdcall 
>> and trying to recompile everything to see if the __stdcall
>> is still needed. 
> 
> Thanks.
> 
> Sasha
>