[openib-general] [PATCH 5 of 5] IB/mthca: give reserved MTTs a separate cache line

Roland Dreier rdreier at cisco.com
Thu Jan 4 19:54:28 PST 2007


 > +	/* CPU writes to non-reserved MTTs, while HCA might DMA to reserved mtts */
 > +	mdev->limits.reserved_mtts = max(dma_get_cache_alignment() / (int)sizeof(u64),
 > +					 mdev->limits.reserved_mtts);

I don't follow this -- first of all, what guarantee is there that the
reserved MTTs end on a cacheline boundary just because they take up
more than a single cacheline?  It seems this should really be using
ALIGN() somehow.

Second, isn't reserved_mtts in units of 64 bytes, not sizeof(u64)?




More information about the general mailing list