[openib-general] [PATCH/RFC] IB/ipoib: add selective tx signaling

[Michael S. Tsirkin]

> I don't think that holding the skb too long is a trigger for somethink. 


Are you sure? We are not talking about too long here - unsignalled TX packet
will never get a completion. As far as I can see, __kfree_skb will
1. call dst_release - so this patch might keep a reference on dst indefinitely?
2. call skb->destructor if not NULL - this is responsible for socket buffer
   accounting
3. Releases reference to lots of other objects related to netfiltering

Are you sure keeping all these references indefinitely is safe?

-- 
MST