[openib-general] [PATCH RFC] return qp pointer as part of ib_wc
Roland Dreier
rdreier at cisco.com
Tue Jan 9 21:08:48 PST 2007
> > this is now returning a pointer to the MAD layer's internal QP. I
> > guess this is OK -- the only user of the pointer seems to be the mthca
> > MAD_IFC command, which just grabs the QP number anyway. But I just
> > wanted to point out this wart...
>
> What's the problem with this?
It's a bit of a layering violation -- a consumer uses the MAD layer
through the agent abstraction and so on, and then ends up getting a
pointer to the MAD layer's QP struct.
I don't think it's really a big deal but it's worth pointing out.
More information about the general
mailing list