[openib-general] [PATCH 1/2] OpenSM: Add socket support to OpenSM console

[Hal Rosenstock]

On Wed, 2007-01-10 at 13:42, Michael S. Tsirkin wrote:
> > Quoting Michael S. Tsirkin <mst at mellanox.co.il>:
> > Subject: Re: [PATCH 1/2] OpenSM: Add socket support to OpenSM console
> > 
> > > diff --git a/osm/opensm/configure.in b/osm/opensm/configure.in
> > > index 1ccf5c6..2d52675 100644
> > > --- a/osm/opensm/configure.in
> > > +++ b/osm/opensm/configure.in
> > > @@ -62,6 +62,22 @@ AC_ARG_ENABLE(debug,
> > >  esac],[debug=false])
> > >  AM_CONDITIONAL(DEBUG, test x$debug = xtrue)
> > >  
> > > +dnl Console over a socket connection
> > > +AC_ARG_ENABLE(console-socket,
> > > +[  --enable-console-socket Enable a console socket, requires tcp_wrappers (default yes)],
> > > +[case $enableval in
> > > +     yes) console_socket=yes ;;
> > > +     no)  console_socket=no ;;
> > > +   esac],
> > > +   console_socket=yes)
> > > +if test $console_socket = yes; then
> > > +  AC_CHECK_LIB(wrap, request_init, [],
> > > + 	AC_MSG_ERROR([request_init() not found. console-socket requires libwrap.]))
> > > +  AC_DEFINE(ENABLE_OSM_CONSOLE_SOCKET,
> > > +	    1,
> > > +	    [Define as 1 if you want to enable a console on a socket connection])
> > > +fi
> > > +
> > >  dnl Provide user option to select vendor
> > >  OPENIB_APP_OSMV_SEL
> > >  
> > 
> > Might it be better to set the default to off?
> > libwrap devel package might not be present on some systems - so build now fails
> > where previously it passed - and user didn't even ask for any new features.
> > 
> > Further, could you please clarify: when compiled in, is opensm listening on a socket
> > by default or does it need to be enabled with a run-time option?
> > I hope it's the later.
> 
> Just to clarify - you guys are going to address these 2 issues, correct?

A patch on the first one (build default) went out yesterday and this is
now in the management git tree.

The second will be addressed shortly.

-- Hal