[openib-general] [PATCH/RFC] IB/ipoib: add selective tx signaling

Michael S. Tsirkin mst at mellanox.co.il
Thu Jan 11 08:22:36 PST 2007


>  > This makes sense but I think you should also consider the fact that 
>  > the tx_lock is taken once per per tx_completion so, with the patch,
>  > the driver spends less time under lock.
> 
> I think we could get rid of the tx lock on completion entirely...
> 
> I have the old patch below lying around.  It no longer applies, and it
> needs some careful thought to make sure there are no memory ordering
> problems (which need to be addressed with appropriate barriers when
> looking at tx_head/tx_tail)

netif_queue_stopped is an atomic, I think that would be sufficient, no?

-- 
MST




More information about the general mailing list