[openib-general] [PATCH] rdma/cma: remove per multicast group qkey usage

Or Gerlitz ogerlitz at voltaire.com
Mon Jan 22 05:11:47 PST 2007


Sean,

Please see the cleanup below, also i see now that librdmacm has two functions
to init a qp: ucma_init_ud_qp for UD QPs and ucma_init_ib_qp for RC QPs,
where the rdmacm kernel code only has ucma_init_ib_qp, i guess something
here is missing (is it only set the QKEY into the UD QP or also modify to
RTR and RTS ? let me know and i can send a patch).

a cleanup on the RDMA CM UD code: remove per group qkey usage for the join flow as this
is impossible to achieve in practice with same UD QP serving attached to multiple group

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>

Index: rdma-dev/drivers/infiniband/core/cma.c
===================================================================
--- rdma-dev.orig/drivers/infiniband/core/cma.c	2007-01-21 12:08:06.000000000 +0200
+++ rdma-dev/drivers/infiniband/core/cma.c	2007-01-21 12:11:16.000000000 +0200
@@ -2434,7 +2434,6 @@ static int cma_join_ib_multicast(struct
 	ib_addr_get_sgid(dev_addr, &rec.port_gid);
 	rec.pkey = cpu_to_be16(ib_addr_get_pkey(dev_addr));
 	rec.join_state = 1;
-	rec.qkey = sin->sin_addr.s_addr;

 	comp_mask = IB_SA_MCMEMBER_REC_MGID | IB_SA_MCMEMBER_REC_PORT_GID |
 		    IB_SA_MCMEMBER_REC_PKEY | IB_SA_MCMEMBER_REC_JOIN_STATE |




More information about the general mailing list