[openib-general] [PATCH RFC 1 of 5] IB/sa: QoS support

Michael S. Tsirkin mst at mellanox.co.il
Mon Jan 22 10:28:44 PST 2007


> Quoting Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH RFC 1 of 5] IB/sa: QoS support
> 
> >  static const struct ib_field path_rec_table[] = {
> > -	{ RESERVED,
> > -	  .offset_words = 0,
> > -	  .offset_bits  = 0,
> > -	  .size_bits    = 32 },
> > -	{ RESERVED,
> > -	  .offset_words = 1,
> > +	{ PATH_REC_FIELD(service_id),
> > +	  .offset_words = 2,
> 
> I haven't read the proposed annex, but I would have expected this to be 
> offset_words = 0.  Otherwise, it seems that the service_id would fall over the dgid.

Thanks, good catch.

-- 
MST




More information about the general mailing list