[openib-general] [PATCH] IB/SRP add need_reset
Michael S. Tsirkin
mst at mellanox.co.il
Mon Jan 22 11:15:58 PST 2007
> Quoting ishai <ishai at dev.mellanox.co.il>:
> Subject: [PATCH] IB/SRP add need_reset
>
>
> When there is a call to send_tsk_mgmt it posts a send and waits for 5 seconds
> to get a response.
> When the QP is in an error state it is obvious that there will be no response
> so it is quite useless to wait.
> This timeout causes SRP to wait a long time to reconnect. (Each abort and
> each reset_device call send_tsk_mgmt that waits for the timeout).
> The following patch solves this problem by identifying the failure
> and returning an immediate error code.
>
> Signed-off-by: Ishai Rabinovitz <ishai at mellanox.co.il>
> ---
> Hi Roland,
>
> This is an old patch. We thought at first that the timeout is because there
> is a bug in low level driver. After rechecking it, I found that the bug is
> internal to SRP.
Roland, could you look at this again please?
This addresses a real issue seen by Ishai, and his explanation
for why this helps sounds convincing.
--
MST
More information about the general
mailing list